Skip to content

StackNode: Fix outputNode flow propagation#33405

Merged
sunag merged 2 commits intomrdoob:devfrom
sunag:dev-fix-stack
Apr 23, 2026
Merged

StackNode: Fix outputNode flow propagation#33405
sunag merged 2 commits intomrdoob:devfrom
sunag:dev-fix-stack

Conversation

@sunag
Copy link
Copy Markdown
Collaborator

@sunag sunag commented Apr 17, 2026

Fixes #33341

Description

Fix the propagation of the outputNode flow from StackNode, where it was calling getNodeType() before setup().

/cc @shotamatsuda

@sunag sunag added this to the r185 milestone Apr 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 365.3
86.77
365.3
86.77
+0 B
+0 B
WebGPU 639.06
177.42
639.04
177.42
-18 B
-3 B
WebGPU Nodes 637.18
177.13
637.16
177.13
-18 B
-4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 497.82
121.45
497.82
121.45
+0 B
+0 B
WebGPU 710.84
192.25
710.82
192.25
-18 B
-5 B
WebGPU Nodes 660.06
179.57
660.04
179.57
-18 B
-5 B

@sunag sunag marked this pull request as ready for review April 20, 2026 22:22
@sunag sunag merged commit c5ef44e into mrdoob:dev Apr 23, 2026
10 checks passed
@sunag sunag deleted the dev-fix-stack branch April 23, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TSL: renderer.debug.getShaderAsync throws for nested struct member access

1 participant